Open
Conversation
Owner
Author
|
It'd be nice to get as many of the SQF PRs merged as we can relatively soon. I also want to do that parser and it'd be easier to change it all at once. I think it is going to be more work with the inspector code |
* Initial plan * Optimize preprocessor performance: Cow<str> for Symbol, HashMap source lookup, optimized extract(), borrow sources() Co-authored-by: BrettMayson <3946739+BrettMayson@users.noreply.github.com> * Address code review: use Option for extract bounds, avoid unnecessary replace allocation Co-authored-by: BrettMayson <3946739+BrettMayson@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: BrettMayson <3946739+BrettMayson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was hoping it'd be a bit faster out of the box, but ACE also isn't that config heavy