Conversation
gausnes
reviewed
Mar 9, 2022
| "rimraf": "^2.6.3", | ||
| "rxjs": "^6.5.2" | ||
| "rxjs": "^7.1.0", | ||
| "@nestjs/axios": "^0.0.6" |
There was a problem hiding this comment.
We should add a variable for setting the axios version
| "@nestjs/common": "^{{nestVersion}}", | ||
| "@nestjs/core": "^{{nestVersion}}", | ||
| "@nestjs/platform-express": "^{{nestVersion}}", | ||
| "@nestjs/config": "1.1.6", |
There was a problem hiding this comment.
We should add a variable for setting the config version, some of our applications are using 1.2.0 already
| public static final String STRING_ENUMS_DESC = "Generate string enums instead of objects for enum values."; | ||
|
|
||
| protected String nestVersion = "6.0.0"; | ||
| protected String nestVersion = "8.3.1"; |
There was a problem hiding this comment.
We should default this to 8.4.0, I ran into some issues installing fastify plugins on 8.3.x
| @Global() | ||
| @Module({ | ||
| imports: [ HttpModule ], | ||
| imports: [ HttpModule, ConfigModule ], |
| public {{nickname}}({{#allParams}}{{^isConstEnumParam}}{{paramName}}{{^required}}?{{/required}}: {{{dataType}}}, {{/isConstEnumParam}}{{/allParams}}): Observable<AxiosResponse<{{#returnType}}{{{returnType}}}{{#isResponseTypeFile}}|undefined{{/isResponseTypeFile}}{{/returnType}}{{^returnType}}any{{/returnType}}>>; | ||
| public {{nickname}}({{#allParams}}{{^isConstEnumParam}}{{paramName}}{{^required}}?{{/required}}: {{{dataType}}}, {{/isConstEnumParam}}{{/allParams}}): Observable<any> { | ||
| public {{nickname}}({{#allParams}}{{^isConstEnumParam}}{{paramName}}{{^required}}?{{/required}}: {{{dataType}}}, {{/isConstEnumParam}}{{/allParams}}options?: AxiosRequestConfig): Observable<AxiosResponse<{{#returnType}}{{{returnType}}}{{#isResponseTypeFile}}|undefined{{/isResponseTypeFile}}{{/returnType}}{{^returnType}}any{{/returnType}}>>; | ||
| public {{nickname}}({{#allParams}}{{^isConstEnumParam}}{{paramName}}{{^required}}?{{/required}}: {{{dataType}}}, {{/isConstEnumParam}}{{/allParams}}options?: AxiosRequestConfig): any { |
There was a problem hiding this comment.
I was thinking we'd want to pump in the same Configuration object that is being passed into the constructor, like done in the Axios generated clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CORE-225: Added template changes for the Nest JS to support Nest@8.0x
PR checklist