Replace the use of dynamic with Reflection to support AOT by iancooper · Pull Request #270 · BrighterCommand/Darker

iancooper · 2025-04-04T08:01:43Z

This is a replacement for #269 due to merge issues

…it issues in MauiTestApp

codescene-delta-analysis

Gates Passed
4 Quality Gates Passed

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Copilot

Copilot reviewed 54 out of 64 changed files in this pull request and generated 1 comment.

Files not reviewed (10)

Darker.sln: Language not supported
Darker.sln.DotSettings: Language not supported
Directory.Packages.props: Language not supported
SampleMauiTestApp/App.xaml: Language not supported
SampleMauiTestApp/AppShell.xaml: Language not supported
SampleMauiTestApp/MainPage.xaml: Language not supported
SampleMauiTestApp/Platforms/Android/AndroidManifest.xml: Language not supported
SampleMauiTestApp/Platforms/Android/Resources/values/colors.xml: Language not supported
SampleMauiTestApp/Platforms/MacCatalyst/Entitlements.plist: Language not supported
SampleMauiTestApp/Platforms/MacCatalyst/Info.plist: Language not supported

Copilot · 2025-04-04T08:03:49Z

SampleMauiTestApp/MainPage.xaml.cs

+        {
+            if (int.TryParse(numberEntry.Text, out int number))
+            {
+                ;


Remove the extraneous semicolon on this line; it appears to be a leftover statement.

Suggested change

;

Removed the extra semicolon. Kinda embarrassed by this. :)

@iancooper Unfortunately, I don't have permission to push the change to the new branch. I will refork the Dark repository to see if that helps. It might be easier for you to make this change for me.

Let me see if I can build, get in the first version, and then you ought to be able to merge. Not quite sure why this repository is behaving this way. The branch protection looks sensible.

codescene-delta-analysis

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

iancooper · 2025-04-04T08:09:19Z

@SteveBush Moving your PR here. GitHub refused to allow me to resolve merge issues with updates to package dependencies. Resolving here.

codescene-delta-analysis

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

iancooper · 2025-04-04T10:43:45Z

@SteveBush I need to look at our build here so that we can get Maui working. It needs a Windows build, not a Linux build. I may look at both a Windows and Linux build, so that we can only build the Maui samples on the Windows build

SteveBush · 2025-04-04T10:50:32Z

@SteveBush I need to look at our build here so that we can get Maui working. It needs a Windows build, not a Linux build. I may look at both a Windows and Linux build, so that we can only build the Maui samples on the Windows build.

@iancooper This seems like a lot of work for you. I'm happy to either do the job or remove the MAUI test project as it served its purpose.

iancooper · 2025-04-04T11:58:28Z

@SteveBush I'll time box it. If we have folks using it for Maui, then it makes some sense. In the worst case, I can move the sample to a separate repo. But, hell, I may learn something.

codescene-delta-analysis

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Copilot

Copilot reviewed 56 out of 65 changed files in this pull request and generated 3 comments.

Files not reviewed (9)

Darker.sln: Language not supported
Darker.sln.DotSettings: Language not supported
Directory.Packages.props: Language not supported
SampleMauiTestApp/App.xaml: Language not supported
SampleMauiTestApp/AppShell.xaml: Language not supported
SampleMauiTestApp/MainPage.xaml: Language not supported
SampleMauiTestApp/Platforms/Android/AndroidManifest.xml: Language not supported
SampleMauiTestApp/Platforms/Android/Resources/values/colors.xml: Language not supported
SampleMauiTestApp/Platforms/MacCatalyst/Entitlements.plist: Language not supported

Copilot · 2025-04-07T08:09:23Z

SampleMauiTestApp/MainPage.xaml.cs

+            if (int.TryParse(numberEntry.Text, out int number))
+            {
+                ;
+                var person = _queryProcessor.ExecuteAsync(new GetPersonNameQuery(number)).Result;


Using .Result on an asynchronous operation may cause deadlocks in the UI thread. Consider making the event handler async and using await.

Copilot · 2025-04-07T08:09:23Z

SampleMauiTestApp/MainPage.xaml.cs

+        private void OnAllPeopleButtonClicked(object sender, EventArgs e)
+        {
+            var people = _queryProcessor.ExecuteAsync(new GetPeopleQuery()).Result;
+


Blocking on asynchronous tasks using .Result in a UI event handler can lead to deadlocks. Refactor the code to use async/await for better responsiveness.

Suggested change

private void OnAllPeopleButtonClicked(object sender, EventArgs e)

{

var people = _queryProcessor.ExecuteAsync(new GetPeopleQuery()).Result;

private async void OnAllPeopleButtonClicked(object sender, EventArgs e)

{

var people = await _queryProcessor.ExecuteAsync(new GetPeopleQuery());

Copilot · 2025-04-07T08:09:23Z

SampleMauiTestApp/Domain/SomethingWentTerriblyWrongException.cs

@@ -0,0 +1,6 @@
+namespace SampleMauiTestApp.Domain
+{
+    public sealed class SomethingWentTerriblyWrongException : Exception


[nitpick] Consider adding standard exception constructors (e.g. parameterless, message, and inner exception overloads) to improve error reporting and usability.

SteveBush and others added 7 commits April 2, 2025 10:05

Validation tests for AOT support

4d10112

MAUI TestApp

b0c7bc5

Update SampleMauiTestApp.csproj

8c98e7a

Remove use of dynamic

155893d

Refactor test helper into Paramare.Test.Helpers project. Fix some awa…

22cf26f

…it issues in MauiTestApp

fix: upgrade to net8 and net9 and fix package dependencies

8601b93

chore: update dependencies

43b8643

iancooper requested review from DevJonny, holytshirt and preardon as code owners April 4, 2025 08:01

codescene-delta-analysis bot approved these changes Apr 4, 2025

View reviewed changes

Merge branch 'master' into NetworkVisor-dev-removedynamic

628accd

codescene-delta-analysis bot approved these changes Apr 4, 2025

View reviewed changes

iancooper requested a review from Copilot April 4, 2025 08:03

Copilot AI reviewed Apr 4, 2025

View reviewed changes

chore: add maui workloads

eecf46f

iancooper added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code .NET Pull requests that update .net code 3 - Done labels Apr 4, 2025

codescene-delta-analysis bot approved these changes Apr 4, 2025

View reviewed changes

chore: update GHA for maui build

7e9e0fc

codescene-delta-analysis bot approved these changes Apr 4, 2025

View reviewed changes

chore: exclude Maui sample from the linux based build

79340d8

codescene-delta-analysis bot approved these changes Apr 4, 2025

View reviewed changes

chore: remove maui from build path

de64344

codescene-delta-analysis bot approved these changes Apr 7, 2025

View reviewed changes

iancooper requested a review from Copilot April 7, 2025 08:06

iancooper merged commit 6352a42 into master Apr 7, 2025
6 of 7 checks passed

iancooper deleted the NetworkVisor-dev-removedynamic branch April 7, 2025 08:07

Copilot AI reviewed Apr 7, 2025

View reviewed changes

Conversation

iancooper commented Apr 4, 2025

Uh oh!

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Uh oh!

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

SteveBush Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

SteveBush Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

iancooper Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Uh oh!

iancooper commented Apr 4, 2025

Uh oh!

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Uh oh!

iancooper commented Apr 4, 2025

Uh oh!

SteveBush commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iancooper commented Apr 4, 2025

Uh oh!

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Uh oh!

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SteveBush commented Apr 4, 2025 •

edited

Loading