Skip to content

[MA-38]: MM-45724: [P3] Webapp/ATE: Accessibility on ATE unexpectedly able to tab on hidden formatting controls/buttons#30

Open
ayush-chauhan233 wants to merge 3 commits intomasterfrom
MM-45724
Open

[MA-38]: MM-45724: [P3] Webapp/ATE: Accessibility on ATE unexpectedly able to tab on hidden formatting controls/buttons#30
ayush-chauhan233 wants to merge 3 commits intomasterfrom
MM-45724

Conversation

@ayush-chauhan233
Copy link

@ayush-chauhan233 ayush-chauhan233 commented Dec 23, 2024

Summary

  • Fixed the tab behaviour for controls in the Advance Text editor.

Steps to reproduce:

  • Click on post text box or comment text box.
  • Press tabs to move focus to Advanced Text Editor controls/buttons until it moves to hidden formatting controls (see screen recording)

Observed:

Hidden element is getting focused and tooltip is showing up.

Expected:

The focus should not be on hidden elements until you click Enter on the button to show and then the focus should continue there as you tab.

Jira Link

https://mattermost.atlassian.net/browse/MM-45724

Video

Before:

398065932-0286a34d-37a0-4e58-b306-b0091699ab5a.webm

After:

398065728-f662383f-9bd9-4af1-911d-a5ac1536518a.webm

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Dec 24, 2024
@Brightscout Brightscout deleted a comment from github-actions bot Dec 24, 2024
@ayush-chauhan233 ayush-chauhan233 changed the title MM-45724: [P3] Webapp/ATE: Accessibility on ATE unexpectedly able to tab on hidden formatting controls/buttons [MA-38]: MM-45724: [P3] Webapp/ATE: Accessibility on ATE unexpectedly able to tab on hidden formatting controls/buttons Dec 24, 2024
@ayush-chauhan233 ayush-chauhan233 added On External Approved Dev approved, ready to be reviewed by MM team labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Dev approved, ready to be reviewed by MM team On External

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants