Skip to content

[MA-21]: Added role='alert' to the error message element#32

Open
ayush-chauhan233 wants to merge 1 commit intomasterfrom
ma_21/issue_mm_61645
Open

[MA-21]: Added role='alert' to the error message element#32
ayush-chauhan233 wants to merge 1 commit intomasterfrom
ma_21/issue_mm_61645

Conversation

@ayush-chauhan233
Copy link

@ayush-chauhan233 ayush-chauhan233 commented Dec 23, 2024

Summary

  • Added role='alert' to the error message element

Steps to reproduce

  • Locate the "Unable to update the channel member." in the notification preference button inside the view info button in the channel header form field with an inline error.
  • Inspect its element with Chrome DevTools.
  • In the Accessibility tab, expand the Computed Properties section.

Review the value for "Description".

Expected Behavior

  • The screen reader should announce the selected to keyboard interacted suggested item correctly.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61645

Screenshots

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Dec 23, 2024
@ayush-chauhan233 ayush-chauhan233 added On External Approved Dev approved, ready to be reviewed by MM team labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ayush-chauhan233 ayush-chauhan233

Labels

Approved Dev approved, ready to be reviewed by MM team On External

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ayush-chauhan233 @SaurabhSharma-884