Skip to content

[MA-32]: Added logic to correctly give accessible name to channel header button#34

Open
ayush-chauhan233 wants to merge 2 commits intomasterfrom
ma_32/issue_mm_61646
Open

[MA-32]: Added logic to correctly give accessible name to channel header button#34
ayush-chauhan233 wants to merge 2 commits intomasterfrom
ma_32/issue_mm_61646

Conversation

@ayush-chauhan233
Copy link

@ayush-chauhan233 ayush-chauhan233 commented Dec 24, 2024

Summary

  • Added aria-labelled by to system bot heading in the channel header
  • Updated the aria-label on the channel header button to announce the channel name correctly.
  • Removed aria-label from the disable calls button

Steps to reproduce

  • Locate the Town Square button control.
  • Inspect it with Chrome DevTools.
  • In the Accessibility tab, expand the Computed Properties section.
  • Review the value for "Name".
  • Notice that this value does not include the visible text of the control as a substring.
  • Review the value for "Description".

Expected Behavior

  • The screen reader must announce the accessible button name correctly.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61646

Screenshots

Before After

Release Note

NONE

>
<span>
<span
id='channelHeaderTitle.bot'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id='channelHeaderTitle.bot'
id='channelHeaderTitle_bot'

@ayush-chauhan233 ayush-chauhan233 added On External Approved Dev approved, ready to be reviewed by MM team labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Dev approved, ready to be reviewed by MM team On External

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants