Skip to content

[MA-19]: MM-61641: Ensure implicit list markup is avoided#35

Open
ayush-chauhan233 wants to merge 2 commits intomasterfrom
MM-61641
Open

[MA-19]: MM-61641: Ensure implicit list markup is avoided#35
ayush-chauhan233 wants to merge 2 commits intomasterfrom
MM-61641

Conversation

@ayush-chauhan233
Copy link

@ayush-chauhan233 ayush-chauhan233 commented Dec 24, 2024

Summary

  • There is content that appears as a list but does not use list markup.
  • Added ul and li tags to structure the list correctly.

Steps to reproduce

  • Locate the White check mark, +1, Grinning, Add reaction, save message, Message actions, Reply and More buttons list by hovering a message element.
  • Inspect it with Chrome DevTools.
  • Note that it does not use ul, li and related elements.

Ticket Link

https://mattermost.atlassian.net/browse/MM-61641

Expected behaviour

The list should be structured with correct semantic tags.

Screenshots

before after
image image

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Dec 24, 2024
@ayush-chauhan233 ayush-chauhan233 changed the title MM-61641: Ensure implicit list markup is avoided [MA-19]: MM-61641: Ensure implicit list markup is avoided Dec 24, 2024
@ayush-chauhan233 ayush-chauhan233 added Approved Dev approved, ready to be reviewed by MM team On External labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Dev approved, ready to be reviewed by MM team On External

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants