MM-61616: Add tab roles inside Emoji Picker#37
Open
ayush-chauhan233 wants to merge 4 commits intomasterfrom
Open
MM-61616: Add tab roles inside Emoji Picker#37ayush-chauhan233 wants to merge 4 commits intomasterfrom
ayush-chauhan233 wants to merge 4 commits intomasterfrom
Conversation
SaurabhSharma-884
suggested changes
Jan 10, 2025
There was a problem hiding this comment.
Suggested change
| role='tab' | |
| role='tab' | |
| type='button' |
ayush-chauhan233
force-pushed
the
MM-61616
branch
from
9585101 to
88ec914
Compare
SaurabhSharma-884
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are tabs without appropriate role, and state information. Examples include:
-Recently Used, Smileys & Emotion, People & Body, Animals & Nature, Food & Drink, Travel Places, Activities, Objects, Symbols, Flags and Custom tab controls
Steps to reproduce
Navigate to Recently Used, Smileys & Emotion, People & Body, Animals & Nature, Food & Drink, Travel Places, Activities, Objects, Symbols, Flags and Custom tab controls.
Inspect the element.
Notice that the Recently Used, Smileys & Emotion, People & Body, Animals & Nature, Food & Drink, Travel Places, Activities, Objects, Symbols, Flags and Custom tab controls are incorrectly coded as a link.
Note: Due to the structure of the component, we couldn't comply with accessibility requirements completely.
Ticket Link
https://mattermost.atlassian.net/browse/MM-61616
Screenshots
Release Note