Skip to content

[MA-45]: Updated the heading element tag#47

Open
ayush-chauhan233 wants to merge 1 commit intomasterfrom
ma_45/issue_mm_61684
Open

[MA-45]: Updated the heading element tag#47
ayush-chauhan233 wants to merge 1 commit intomasterfrom
ma_45/issue_mm_61684

Conversation

@ayush-chauhan233
Copy link

Summary

  • Updated the user settings and team settings modal title component HTML tag from h1 to h2.

Steps to reproduce

  • Locate the Settings text heading.
  • Inspect it with Chrome DevTools.
  • In the Accessibility tab, expand the Computed Properties section.
  • Review the value for "Level".

Expected behaviour

  • The heading does not match with the visual level on the page, Hence the modal heading should be h2.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61684

Screenshots

Before After

Release Note

NONE


&__title {
color: var(--center-channel-color);
font-family: 'Metropolis', serif;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From where are we adding these styles?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took reference from notification header
Screenshot from 2025-01-13 16-49-15

@ayush-chauhan233 ayush-chauhan233 added On External Approved Dev approved, ready to be reviewed by MM team labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Dev approved, ready to be reviewed by MM team Merged On External

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants