Skip to content

MM-61685: Provide visual labels or instructions for user input#51

Open
SaurabhSharma-884 wants to merge 1 commit intomasterfrom
MM-61685
Open

MM-61685: Provide visual labels or instructions for user input#51
SaurabhSharma-884 wants to merge 1 commit intomasterfrom
MM-61685

Conversation

@SaurabhSharma-884
Copy link

@SaurabhSharma-884 SaurabhSharma-884 commented Jan 3, 2025

Summary

The Keywords that trigger notifications edit field label is not descriptive and also additional information is not associated with the edit field.

Steps to reproduce

  • Navigate to the Keywords that trigger notifications edit button and select it.
  • Now navigate to the Keywords that trigger notifications edit field.
  • Notice that the label is not descriptive for the edit field and and also additional information is not associated with the edit field.

Ticket Link

https://mattermost.atlassian.net/browse/MM-61685

Screenshots

before after
image image

Release Note

NONE

Copy link

@ayush-chauhan233 ayush-chauhan233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not able to locate referenced aria-describedby attribute in the input element

@SaurabhSharma-884
Copy link
Author

Not able to locate referenced aria-describedby attribute in the input element

aria-describedby prop is being overridden internally. This seems to be a library issue.

https://github.com/JedWatson/react-select/blob/179b8166cafc6540ec7a3c6091320c18b8aff75a/packages/react-select/src/Select.tsx#L1742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants