Skip to content

Enhance Tests: button-move #6300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Enhance Tests: button-move #6300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af0bd0c
Enhance Tests: button-move
margaree Nov 13, 2025
9cb6ded
remove duplicate test
margaree Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions components/button/test/button-move.axe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,34 @@ describe('d2l-button-move', () => {
expect(description.innerText).to.equal('secondary');
});

it('partially disabled (up)', async() => {
const el = await fixture(html`<d2l-button-move text="Reorder Item" disabled-up></d2l-button-move>`);
await expect(el).to.be.accessible();
});

it('partially disabled (down)', async() => {
const el = await fixture(html`<d2l-button-move text="Reorder Item" disabled-down></d2l-button-move>`);
await expect(el).to.be.accessible();
});

it('partially disabled (left)', async() => {
const el = await fixture(html`<d2l-button-move text="Reorder Item" disabled-left></d2l-button-move>`);
await expect(el).to.be.accessible();
});

it('partially disabled (right)', async() => {
const el = await fixture(html`<d2l-button-move text="Reorder Item" disabled-right></d2l-button-move>`);
await expect(el).to.be.accessible();
});

it('autofocus', async() => {
const el = await fixture(html`<d2l-button-move text="Reorder Item" autofocus></d2l-button-move>`);
await expect(el).to.be.accessible();
});

it('dark theme', async() => {
const el = await fixture(html`<d2l-button-move text="Reorder Item" theme="dark"></d2l-button-move>`);
await expect(el).to.be.accessible();
});

});
81 changes: 80 additions & 1 deletion components/button/test/button-move.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { clickElem, expect, fixture, html, oneEvent, runConstructor, sendKeysElem } from '@brightspace-ui/testing';
import { aTimeout, clickElem, expect, fixture, html, oneEvent, runConstructor, sendKeysElem } from '@brightspace-ui/testing';
import { moveActions } from '../button-move.js';

describe('d2l-button-move', () => {
Expand Down Expand Up @@ -33,6 +33,85 @@ describe('d2l-button-move', () => {
});
});

it('does not bubble events', async() => {
const el = await fixture(html`<div><d2l-button-move text="Reorder"></d2l-button-move></div>`);
const button = el.querySelector('d2l-button-move');
let bubbledEvent = false;
el.addEventListener('d2l-button-move-action', () => bubbledEvent = true);
await clickElem(button.shadowRoot.querySelector('.up-layer'));
expect(bubbledEvent).to.be.false;
});

});

describe('disabled states prevent events', () => {

[
{ name: 'disabled-up prevents up click', disabledProp: 'disabledUp', action: el => clickElem(el.shadowRoot.querySelector('.up-layer')) },
{ name: 'disabled-down prevents down click', disabledProp: 'disabledDown', action: el => clickElem(el.shadowRoot.querySelector('.down-layer')) },
{ name: 'disabled-up prevents up key', disabledProp: 'disabledUp', action: el => sendKeysElem(el.shadowRoot.querySelector('button'), 'press', 'ArrowUp') },
{ name: 'disabled-down prevents down key', disabledProp: 'disabledDown', action: el => sendKeysElem(el.shadowRoot.querySelector('button'), 'press', 'ArrowDown') },
{ name: 'disabled-left prevents left key', disabledProp: 'disabledLeft', action: el => sendKeysElem(el.shadowRoot.querySelector('button'), 'press', 'ArrowLeft') },
{ name: 'disabled-right prevents right key', disabledProp: 'disabledRight', action: el => sendKeysElem(el.shadowRoot.querySelector('button'), 'press', 'ArrowRight') },
{ name: 'disabled-home prevents home key', disabledProp: 'disabledHome', action: el => sendKeysElem(el.shadowRoot.querySelector('button'), 'press', 'Home') },
{ name: 'disabled-home prevents ctrl-home key', disabledProp: 'disabledHome', action: el => sendKeysElem(el.shadowRoot.querySelector('button'), 'press', 'Control+Home') },
{ name: 'disabled-end prevents end key', disabledProp: 'disabledEnd', action: el => sendKeysElem(el.shadowRoot.querySelector('button'), 'press', 'End') },
{ name: 'disabled-end prevents ctrl-end key', disabledProp: 'disabledEnd', action: el => sendKeysElem(el.shadowRoot.querySelector('button'), 'press', 'Control+End') }
].forEach(info => {
it(`${info.name}`, async() => {
const el = await fixture(html`<d2l-button-move text="Reorder"></d2l-button-move>`);
el[info.disabledProp] = true;
await el.updateComplete;
let eventDispatched = false;
el.addEventListener('d2l-button-move-action', () => eventDispatched = true);
await info.action(el);
await aTimeout(50); // wait to ensure event is not dispatched
expect(eventDispatched).to.be.false;
});
});

});

describe('properties', () => {
Copy link
Contributor Author

@margaree margaree Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could arguably be moved into the axe file


it('button is disabled when all directions are disabled', async() => {
const el = await fixture(html`<d2l-button-move text="Reorder" disabled-up disabled-down disabled-left disabled-right disabled-home disabled-end></d2l-button-move>`);
const button = el.shadowRoot.querySelector('button');
expect(button.disabled).to.be.true;
});

it('button is not disabled when only some directions are disabled', async() => {
const el = await fixture(html`<d2l-button-move text="Reorder" disabled-up disabled-down></d2l-button-move>`);
const button = el.shadowRoot.querySelector('button');
expect(button.disabled).to.be.false;
});

it('text property sets aria-label and title', async() => {
const el = await fixture(html`<d2l-button-move text="Reorder Item"></d2l-button-move>`);
const button = el.shadowRoot.querySelector('button');
expect(button.getAttribute('aria-label')).to.equal('Reorder Item');
expect(button.getAttribute('title')).to.equal('Reorder Item');
});

});

describe('focus', () => {

it('focus() method focuses the button', async() => {
const el = await fixture(html`<d2l-button-move text="Reorder"></d2l-button-move>`);
el.focus();
const button = el.shadowRoot.querySelector('button');
expect(document.activeElement).to.equal(el);
expect(el.shadowRoot.activeElement).to.equal(button);
});

it('autofocus property focuses button on render', async() => {
const el = await fixture(html`<d2l-button-move text="Reorder" autofocus></d2l-button-move>`);
await el.updateComplete;
const button = el.shadowRoot.querySelector('button');
expect(button.hasAttribute('autofocus')).to.be.true;
});

});

});