Draft
Conversation
Collaborator
|
I've changed the gridded climatology method so that it doesn't produce a copy of the original data set - this makes saving the output more difficult. I've check it gets same answer to earlier version - and it does for PEA (bit identical), but not identical SST or SSS. I think because sos_abs ~= so_abs[:,0,:,:] for some reason. But nothign to worry about |
…ecting highly inefficient bit removing code that breaks env`
…Oceanographic-Data-Centre/COAsT into feature/535_stratification_diag Conflicts: coast/data/profile.py
Collaborator
|
@jpolton I've added the match-to-grid capability and found (and fixed) a very slow bit of the code. So this now produces NWS profile dataset 1978-2019 in ~1 hour. So should be practical cycle through all LME's without further optimisation. I'll need some guidance on finishing the pull to develop. |
…ple grids in one file
Passing variables needed for match to grid Remove this version of match to grid as provided in profile Profile sub setting across latitude wrap
added case of no data
…British-Oceanographic-Data-Centre/COAsT into feature/535_stratification_diag
update Zd_mask to exclude density levels with NaN
fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
A couple of diagnostics files are separated from the SE-NEMO branch as they are without unit testing. This means they can not be maintained.
These files have been edited for consistency with COAsT conventions.
They also have some COMMENTS within.
Without worked examples and testable code, this will not age well and so is not ready for develop.
AC (for discussion):