Skip to content

Set value and fire a change event, close #1632 #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Set value and fire a change event, close #1632 #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f66687
Set value and fire a change event, close #1632
May 24, 2019
850c98b
supports HTMLInputElement and HTMLTextAreaElement
May 24, 2019
3809bc4
use 4 spaces format
May 24, 2019
107cd07
make it also works for SELECT
May 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/browser-sync-client/lib/effects/set-element-toggle-value.effect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ export function setElementToggleValueEffect(
match.checked = event.checked;
}
if (event.tagName === "SELECT") {
match.value = event.value;
const nativeInputValueSetter = Object.getOwnPropertyDescriptor(Object.getPrototypeOf(match), 'value').set;
nativeInputValueSetter.call(match, event.value);
match.dispatchEvent(new Event('change', { bubbles: true }));
}
}
})
Expand Down
4 changes: 3 additions & 1 deletion packages/browser-sync-client/lib/effects/set-element-value.effect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ export function setElementValueEffect(
const elems = document.getElementsByTagName(event.tagName);
const match = elems[event.index];
if (match) {
(match as HTMLInputElement).value = event.value;
const nativeInputValueSetter = Object.getOwnPropertyDescriptor(Object.getPrototypeOf(match), 'value').set;
nativeInputValueSetter.call(match, event.value);
match.dispatchEvent(new Event('change', { bubbles: true }));
}
})
);
Expand Down