Rewrite curl implementation using Plenary and add cancel stream functionality#45
Open
alizdavoodi wants to merge 1 commit intoBryley:mainfrom
Open
Rewrite curl implementation using Plenary and add cancel stream functionality#45alizdavoodi wants to merge 1 commit intoBryley:mainfrom
alizdavoodi wants to merge 1 commit intoBryley:mainfrom
Conversation
…sage to properly handle JSON chunks. 2. Added a function to cancel the current stream and shut down the handler in openai.lua. 3. Removed an unnecessary newline in history.lua. 4. Migrated from custom curl implementation to the plenary curl module for better functionality and streamlined code. 5. Added a mapping in ui.lua to cancel the stream using the new cancel_stream() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
In this MR, I am introducing a new dependency called https://github.com/nvim-lua/plenary.nvim. Plenary is a highly useful plugin with a variety of functions that simplifies the module.
Changes contains:
cancel_streamhas been added to the OpenAI model. This function enables users to cancel the current stream and gracefully shut down the handler. This additional functionality provides better control and an improved user experience.(Additionally, there is a new keybinding Ctrl-X to cancel the stream, and if you close the NeoAI window while streaming, the stream will be canceled.)