fix: pipeline execution failures and hide dev features

[dittops]

Summary

• fix(budcluster): Handle explicit None for scaleToZeroConfig - prevents NoneType.get() error when scaling deployments to 0 replicas
• fix(budpipeline): Finalize execution status on step failure - ensures failed pipelines show status=FAILED instead of staying stuck
• feat(budadmin): Hide Tools and Pipelines menu items behind dev mode flag

Changes

budcluster/deployment/handler.py

Changed budaiscaler.get("scaleToZeroConfig", {}) to budaiscaler.get("scaleToZeroConfig") or {} to handle the case where scaleToZeroConfig is explicitly set to None.

budpipeline/handlers/event_router.py

Added session.commit() and _check_and_finalize_execution() calls after both failure paths (exception and result.success=False) to ensure the execution status is properly marked as FAILED.

budadmin/pages/home/layout.tsx

Added hide: !enableDevMode to Tools and Pipelines menu items so they are only visible in dev builds.

Test plan

• Deploy updated budcluster and budpipeline pods
• Re-run a pipeline that scales deployments to 0 replicas
• Verify the pipeline completes (or fails with proper status=FAILED)
• Build budadmin without NEXT_PUBLIC_ENABLE_DEV_MODE - verify Tools/Pipelines hidden
• Build budadmin with NEXT_PUBLIC_ENABLE_DEV_MODE=true - verify Tools/Pipelines visible

Deployment notes

• budcluster/budpipeline: Pod restart required
• budadmin: Docker rebuild required with appropriate build arg:
  • Dev: docker build --build-arg NEXT_PUBLIC_ENABLE_DEV_MODE=true ...
  • Prod: docker build ... (default hides dev features)

🤖 Generated with Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[gemini-code-assist]

Summary of Changes

Hello @dittops, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses critical bug fixes in the budcluster and budpipeline services, enhancing the reliability of deployment scaling and pipeline execution status reporting. Additionally, it introduces a new feature in budadmin to control the visibility of development-specific UI elements, improving the user experience for different environments.

Highlights

• Budcluster Fix: Correctly handles explicit None values for scaleToZeroConfig to prevent NoneType.get() errors when scaling deployments to zero replicas.
• Budpipeline Fix: Ensures pipeline execution status is finalized as FAILED immediately upon step failure, preventing pipelines from appearing stuck.
• Budadmin Feature: Introduces a development mode flag to hide "Tools" and "Pipelines" menu items in the UI, making them visible only in dev builds.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces fixes for pipeline execution failures, handles a potential NoneType error, and hides development features behind a feature flag. The changes in budadmin and budcluster look good and correctly address the described issues. However, the fix in budpipeline for handling pipeline failures is not complete and may still result in pipelines getting stuck. I've added a critical comment explaining the issue. I've also added a medium-severity comment about code duplication in the same file.

[gemini-code-assist]

This change attempts to finalize the pipeline on step failure, but it is unlikely to work as intended. The _check_and_finalize_execution function will only set the final status if there are no PENDING or RUNNING steps. When a step fails, other steps in the pipeline will likely remain PENDING, so _check_and_finalize_execution will return early, and the pipeline will remain stuck instead of being marked as FAILED. The continue also means other parallel steps will be executed even after a failure, which may be undesirable.

[dittops]

Fixed in commit 22afccb. Implemented fail-fast behavior:

1. When a step fails and no steps are running, all pending steps are marked as SKIPPED
2. The execution is then finalized as FAILED

This ensures pipelines don't get stuck when a step fails.

[gemini-code-assist]

This block of failure handling logic is duplicated from lines 756-758. To improve maintainability, consider extracting this logic into a private helper function that can be called from both failure paths (here and in the except block).

For example:

async def _handle_failure_and_finalize(session: AsyncSession, step_crud: StepExecutionCRUD, execution_id: UUID):
    """Commits session changes and finalizes the execution status after a step failure."""
    await session.commit()
    # A more robust failure handling logic should be implemented here
    # to ensure the pipeline doesn't get stuck.
    updated_steps = await step_crud.get_by_execution_id(execution_id)
    await _check_and_finalize_execution(session, execution_id, updated_steps)

This would also be a good place to implement a more robust failure handling strategy that addresses the issue of stuck pipelines mentioned in the other comment.

[dittops]

Fixed in commit 22afccb. Extracted the duplicated logic into _commit_and_finalize_on_failure() helper function which is now used in both failure paths.