-
Notifications
You must be signed in to change notification settings - Fork 3
fix(budadmin): agent details UI improvements #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
athul-ab
commented
Feb 6, 2026
- Hide Previous Version section when no previous versions exist
- Replace inline HomeIcon SVG with vector house icon supporting dynamic color
- Fix HTML comment in JSX causing parse error
- Hide Previous Version section when no previous versions exist - Replace inline HomeIcon SVG with vector house icon supporting dynamic color - Fix HTML comment in JSX causing parse error Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @athul-ab, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces several UI enhancements to the budadmin agent details page. Key changes include optimizing the display of agent version history by conditionally showing the 'Previous Version' section, improving the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several UI improvements for the agent details page. The conditional rendering of the 'Previous Versions' section is a good enhancement, making the UI cleaner when no previous versions exist. The refactoring of the HomeIcon to a simpler vector-based SVG is also a positive change for maintainability. However, the addition of a new SVG file (home.svg) that contains a large base64-encoded PNG is a significant concern. This approach undermines the benefits of using SVGs and should be addressed. Other minor styling changes appear to be for UI alignment and are acceptable.
| <svg version="1.2" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128" width="128" height="128"> | ||
| <defs> | ||
| <image width="128" height="116" id="img1" href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAIAAAAB0CAMAAAB648r2AAAAAXNSR0IB2cksfwAAAlVQTFRFAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAwZolLQAAAMd0Uk5TAAIapvilROf/60wEgP3+kQcgx80lVO/yXAmiDCvT2TEBbcAQqvwDb/qxEzjf4z433g+pBRzBXvUhTuzYMPBVCifO1CzzzCQfxvYNowarM9rqS+Y5+b4Wt/sUtLsYQeXhPDbd6UeuEg6nHcP3ySJQ7dcvKdFYCAso0PFZUe7WLfTKIx7ErRE03ElCO7wZFbW2veA626yky1LVz1rSV0/Cr+hA5OK6s7gbMiaZiE1mf2ewkC6/YF17eXFFko59aGqHP5SfoLlwcgq9AxYAAAXnSURBVHic7Zt9UBRlHMf3R3lMMYmQYTIwnAGXDZMk75mYTBpIEAwaxcvVhCTojDIix5uNTaSM5yDRpIKAhFEoCWJCBKbmC441WaGFJWnRiNiYWTqjM751cbv37O377t3tLo2z3z9uv/fs7vN8Vp797e/53QqYawLM4moHrsgNAIO7/44bgA6spwPcGB8AD4DbiOOfcQDwoly4B1xWHeARuEb55gl/qAsw9cZNRos3XFARwA/+ZLX5wO9qAejh/P3I+2KjyN7xtwyrAhAII8j6X/T9xQDksNPgtAoAIXAW2WA4NfYZCj/TGxQFMIxOPY88uuCZ9guf4Bb0raIAEfADsncCbw4jHwUnkX3Q8JWCAE/Dd8iGQz9lB+W2iIQjSgFMslhuIc+87amBwTv4sCIAc+E4slyBjxIaZ8EBBQCiJpL/5rGwj+OAeDiEbNyvZ+QGSLRflA5iuzmPIR+PY5p/+pysAC9CH7IJ0Ml7mC6pB9mgxzvkA9C7P0lec3KHUAKUDp8im9p9XUq2JgUgA3bbe/UdEjxW726PzAvhI1kAjPAJsi9Ds+jhr0MrslnQ6DqAB9hjrxHqRTvEsDw7pQ5EI7MYwFJoQnbxfqn3FiUy58L7LgGsgK3I5sO7EsfHsELYjGxkdJXzAKZ6SnzN3iB5fMaZgpFZCKAEapBdCZUODG/VaiCv3AQVTgFELTAjWwpvOTg+hlXAOmSFZg8vQF7Tfcjyxl5hUSPzm7DaQYBKeBvZrOBSJ4a3yjxojyAhxY4AUGPvO1Dk5PgYthHKkeWLzJwAG93KxM6TKOqVrC/keopwAZi/Jp9pZljhwvBWVT5kQjYhhuNvyQagzp2qq3xzR7ryZqxClms2swDiZ5N3jwN5jaAo93P1HmYuxQSovUDGj5pRgfjhkEoeK0B25bQlQgDSI6hjMtVT8ml6TKcBFD6xHNnI13JlG96qbad4nmpUAOpT9IRj6xtxLY1chiwtMtsBZkY3Iyshj3Bc1FVl7XEysyEBKJlUXb94JuWMtgM5ARsONNMBqLlkY6+EXNIpZSQtRpbMbgmA9NQctEc/4lLsFZbe/RxZW0lOyyABiIIjriDLoGLDW7VzB7nCgYROAoAae/0sEldUTitx4AqyeGQGzCv6EGqRK/YKi7rK/f4yTE75GH2dNTTCfYrMaqsj1/lhMdCKpp+useCiKuNj2KSGHPRHT4MyW1wMK1yk0vBWtVfbaj0TIYWYlb7eJ1QcH8MirhAFznzoyBrb+JtLhRe98suwvsQamXcA1tk1ZcotnpRVUW0YPrh67RlmQhIwI+TDhSLrSae1vOPVwb/76W0MgJ3tY0lb0V+1ioxfsekahiV9Qy+qMwD2vGL9bEtRBMATT7eMDUIAOfgzOXmXIgAvdVk/M5tojQyAljdwjC2KACzDh24wagAawD0FkGjEWnrED1MGYG+mz6PWh2pY2e0BSatIWQH01586SvlaDeZhVQH88tYxWrb8WK0iQPfmL1ltoWteUA2gJ42rVde2QCWA3lSeHQHCWb1cAH2LyHXM9FwDNlRH/pTrn1uiAkDgiO2cCXMMREYdUFxqQ0p/YCvPWTICeNqqOMERH5BtoatsC++u+YoDVP22Dd+aPKkF1KqROnwb97DA0l4egN2Z+CbvJ3q9bXI+UV3rnqc0gG0h89lzjPaDifgmvwbjlSwAMQP4JvMks4gUfpd4jeHZPoxPsgCUEwH38zjWnl1Ex5v4y3uyANimQO9c1p7tefhGYBLIAnA4Ht+Ur2HtiScKq3ufVxbgCNG/F7uUYCIWdPvmKAtwlIg089g/IoUT1a0vYjUADUAD0AA0AA1AA9AANAANQAPQADSAewHA0sLbSdElEQAf/ldIjSAVQFz8AKL6nwO8J1jqtCuE/Z6RVABzAe0rAyBL2ivx0wc4GnNaORrZ2j9bCKA9W1InnFXpY8zKHbfc6P85kPnref3aS6Jd1AdlDnM061vPLuFopssnm/GCMvuNymJPkT6O8f9KlfiMyLlXWa9n/wc29r6U0S7dAwAAAABJRU5ErkJggg=="/> | ||
| </defs> | ||
| <style> | ||
| </style> | ||
| <use id="Background" href="#img1" x="0" y="6"/> | ||
| </svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a base64-encoded PNG image within an SVG file is not recommended as it defeats the benefits of using vector graphics, such as scalability and small file size. This implementation results in a large file containing a raster image that will not scale cleanly and negatively impacts performance. Please replace this with a pure vector-based SVG. A vector-based SVG will be significantly smaller, render crisply at any size, and allow for dynamic color changes via CSS.
<svg version="1.2" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="128" height="128">
<defs>
</defs>
<style>
</style>
<path fill="currentColor" d="M10 20v-6h4v6h5v-8h3L12 3 2 12h3v8h5z"/>
</svg>
The HomeIcon is now an inline vector SVG, so this base64-encoded PNG-in-SVG file is no longer referenced and should be removed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>