-
Notifications
You must be signed in to change notification settings - Fork 3
fix(budadmin): resolve pipeline description textarea label overlap #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Override InfoLabel's h-[3px] with a high-specificity SCSS class (.textarea-info-label) to ensure the floating label has proper height for text masking. Adjust label top position and textarea padding for correct border alignment at 1440x900 viewport. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @dittops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a user interface defect in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a UI bug where the textarea's floating label overlaps with its content. The changes involve adjusting CSS properties for positioning and size, and introducing a specific class to override styles from a child component. The fix appears correct and well-targeted. I have one suggestion to improve the maintainability of the CSS.
|
|
||
| .textarea-info-label { | ||
| height: auto !important; | ||
| background: var(--color-background) !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
h-[3px]constraint using a high-specificity SCSS class to ensure proper label height for text maskingautoSizeprop to textarea for dynamic height, use CSS variable for label background, and adjust positioning for MacBook resolution (1440x900)Changes
TextArea.tsx: AddedautoSize={{ minRows: 3, maxRows: 8 }}andclassNames="textarea-info-label"to InfoLabelglobals.scss: Added background, label positioning (top: -8px),line-height: 1, and.textarea-info-labeloverride class with proper specificity to beat Tailwind'simportant: trueconfigTest plan
🤖 Generated with Claude Code