Bugfix/agent new

[athul-ab]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @athul-ab, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user experience in two key areas: simplifying the agent creation process and enhancing the log viewing functionality. The 'Add Agent' workflow has been streamlined by removing an unnecessary model selection step, making the process more efficient. Concurrently, the agent logs page has been upgraded to support reverse infinite scrolling for historical data, improving navigation and access to older logs. Additionally, the behavior of live log streaming has been adjusted to append new entries and preserve existing data when switching to live mode, providing a more consistent and user-friendly logging interface.

Highlights

• Add Agent Workflow Simplification: The 'Select Model' step has been removed from the 'Add Agent' workflow, reducing the total steps from 6 to 5 and streamlining the agent creation process.
• Enhanced Log Viewer Experience: The agent logs page now features reverse infinite scrolling, allowing users to load older logs by scrolling to the top. This improves navigation and access to historical data.
• Live Log Display Adjustment: Live logs are now appended to the bottom of the list, and when enabling live mode, existing historical logs are preserved rather than cleared. This provides a more consistent and user-friendly logging interface.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• docs/projects/projects.mdx
  • Removed a trailing newline character for formatting consistency.
• services/budadmin/src/flows/AddAgent/SelectModel.tsx
  • Removed the entire 'SelectModel.tsx' component, eliminating the 'Select Model' step from the Add Agent workflow.
• services/budadmin/src/flows/index.tsx
  • Removed the import and component registration for 'AddAgentSelectModel' to reflect its removal from the workflow.
• services/budadmin/src/hooks/drawerFlows.tsx
  • Updated the 'addAgent' flow to reflect 5 total steps instead of 6.
  • Removed the 'Select Model' step from the progress indicator and step definitions.
  • Adjusted step numbering for subsequent steps in the 'addAgent' flow to account for the removed step.
• services/budadmin/src/pages/home/agentDetails/[agentId]/logs/index.tsx
  • Implemented reverse infinite scrolling for log data, enabling users to load older logs by scrolling to the top.
  • Modified live log handling to append new entries to the bottom of the list.
  • Updated live mode activation to preserve existing historical logs and seed the deduplication set with current span IDs.
  • Adjusted the chart height for better layout and visual presentation.
  • Removed the 'MAX_LIVE_ITEMS' constant and introduced 'TRACES_PER_PAGE' for traces view pagination.
  • Utilized 'useLayoutEffect' to preserve scroll position when prepending new log data.
• services/budadmin/src/stores/useAddAgent.tsx
  • Updated 'workflow_total_steps' to 5 when initiating a new agent workflow, aligning with the removal of the 'Select Model' step.

Activity

• The author athul-ab initiated this pull request.
• The pull request title 'Bugfix/agent new' suggests improvements or fixes related to the agent creation process and potentially the new agent logging functionality.
• The changes indicate a refactoring of the 'Add Agent' workflow and significant enhancements to the log viewing component, including a new scrolling mechanism.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two main changes. First, it refactors the 'Add Agent' flow by removing the separate 'Select Model' step, which simplifies the user experience. The related changes across multiple files are consistent. Second, it significantly refactors the logs view to implement a reverse infinite scroll for historical data and improves the handling of live data. While the reverse scroll is a good UX improvement, I've identified a potential issue with how live data is stored, which could lead to performance problems over time. My review includes a specific comment and suggestion to address this.

[gemini-code-assist]

In live mode, the logsData array is appended with new entries without any size limit. This could lead to performance degradation and high memory usage over time if a large number of traces are received. The previous implementation had a MAX_LIVE_ITEMS limit which has been removed.

It's recommended to re-introduce a limit on the number of items stored for the live view. A similar change should be applied on lines 1202 and 1232.

Suggested change

	setLogsData(prev => [...prev, newEntry]);
	setLogsData(prev => [...prev, newEntry].slice(-200));

References

1. To prevent potential memory leaks and performance degradation, it's important to cap the size of arrays that can grow indefinitely, especially when handling real-time data streams.