fix(budpipeline): persist pipeline icon across full stack #1290
Conversation
The emoji picker in the UI captures icon selection but never sends it to the API, the backend has no icon column, and the listing page hardcodes 🔄 for all pipelines. This adds full-stack icon persistence from DB through to the frontend. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @dittops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the ability for users to assign and persist custom icons to their pipelines. This enhancement provides a more personalized and visually distinct representation of pipelines across the application, from creation and editing in the UI to storage in the database and retrieval through various services. The change impacts the database schema, backend API, and frontend components to ensure seamless integration and display of these new pipeline icons. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully adds an icon field for pipelines, persisting it across the full stack from the database to the frontend. The changes are well-implemented and consistent with the feature description. I have one suggestion to improve the consistency of handling optional parameters in the budapp service, which will make the code more robust.
| data: Dict[str, Any] = { | ||
| "dag": dag, | ||
| "name": name, | ||
| "user_id": user_id, | ||
| "system_owned": system_owned, | ||
| } | ||
| if icon is not None: | ||
| data["icon"] = icon |
There was a problem hiding this comment.
For consistency and to avoid sending None values for optional fields, it would be better to build the data dictionary by only including optional fields (name, user_id, icon) if they are not None. This would align with the pattern used in update_pipeline in this same file, making the code more robust and predictable.
data: Dict[str, Any] = {
"dag": dag,
"system_owned": system_owned,
}
if name is not None:
data["name"] = name
if user_id is not None:
data["user_id"] = user_id
if icon is not None:
data["icon"] = icon
1 participant
Summary
iconcolumn (VARCHAR(255), nullable) topipeline_definitiontable with Alembic migrationiconfield through the full stack: budpipeline (model → schema → CRUD → service → routes) → budapp (service → routes) → budadmin (store → NewPipeline → EditPipeline → listing page)Closes #1260
Changes by layer
budpipeline (backend)
models.py– addediconmapped column006_add_icon...py– new Alembic migrationschemas.py– addedicontoPipelineCreateRequest,PipelineResponse,PipelineDefinitionResponsecrud.py– accepticonincreate()service.py– pass/returniconin create, update, get, list methodsroutes.py– forwardrequest.iconand include in responsesbudapp (proxy)
budpipeline_service.py– forwardiconin create/update Dapr callsbudpipeline_routes.py– extracticonfrom request bodybudadmin (frontend)
useBudPipeline.ts– addediconto type + store function signatures/payloadsNewPipeline.tsx– passvalues.icontocreateWorkflowEditPipeline.tsx– initialize form with pipeline icon, pass toupdateWorkflowbudpipelines/index.tsx– renderworkflow.icon || "🔄"instead of hardcoded emojiMigration
Run
alembic upgrade headon the budpipeline database.Test plan
alembic upgrade headon budpipeline DB and verify column existsalembic downgrade -1removes the column cleanly🤖 Generated with Claude Code