Skip to content

fix: ensure logs header visible in light mode #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jithinAB wants to merge 1 commit into
base: feature/logs-them
Choose a base branch
from
Open

fix: ensure logs header visible in light mode #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions services/budCustomer/src/app/(app)/logs/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ export default function ObservabilityPage() {
<div className="boardPageTop">
<PageHeader
headding="Logs"
hClass="!text-[#000000] dark:!text-[#FFFFFF]"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Aug 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this fixes the visibility issue in light mode, using hardcoded hex color values like #000000 and #FFFFFF is not ideal for maintainability, especially in a themed application. It's better to use Tailwind's built-in color names.

This makes the code more readable and resilient to future theme changes. If the theme's definition of black or white changes, your code will automatically adapt.

Suggested change
hClass="!text-[#000000] dark:!text-[#FFFFFF]"
hClass="!text-black dark:!text-white"

/>
</div>

Expand Down
Loading