Skip to content

fix(helm): temporarily disable nvidia runtimeClassName #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dittops wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(helm): temporarily disable nvidia runtimeClassName #751

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee976b5
fix(helm): temporarily disable nvidia runtimeClassName
dittops Oct 30, 2025
31302db
Merge branch 'feature/hide-dev-mode-features' of https://github.com/B…
dittops Oct 31, 2025
ce2b233
Merge branch 'master' of https://github.com/BudEcosystem/bud-runtime …
dittops Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions services/budcluster/budcluster/charts/bud_runtime_container/templates/single-node.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ spec:
topologyKey: kubernetes.io/hostname
imagePullSecrets:
- name: {{ $.Values.imagePullSecrets.name }}
{{- if eq .node.type "cuda" }}
runtimeClassName: nvidia
{{- end }}
# {{- if eq .node.type "cuda" }}
# runtimeClassName: nvidia
# {{- end }}
Comment on lines +43 to +45
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While commenting out this block achieves the goal, a more idiomatic and maintainable approach for Helm charts is to use a feature flag in values.yaml. This makes the configuration explicit and allows toggling the behavior without changing the template code. This is preferable to leaving commented-out code in the template.

You could add a new value like nvidiaRuntimeClassEnabled to your values.yaml (setting it to false to keep it disabled) and use it here. This would make re-enabling it in the future cleaner.

      {{- if and (eq .node.type "cuda") .Values.nvidiaRuntimeClassEnabled }}
      runtimeClassName: nvidia
      {{- end }}

containers:
{{- if eq .node.type "cpu" }}
{{- include "bud-runtime-container.cpu-container" (dict "Values" $.Values "device" .node) | nindent 6 }}
Expand Down