Skip to content

Conversation

@melohagan
Copy link
Collaborator

@melohagan melohagan commented Dec 11, 2025

Description

Allow a user to add double click and right click events to a container. You must choose between onClick and onDoubleClick - you cannot have both.

Backwards compatibility for existing containers onClick was tested.

Addresses

Screenshots

Screenshot 2025-12-11 at 12 35 29 Screenshot 2025-12-11 at 12 36 04 Screenshot 2025-12-11 at 12 36 18

Launchcontrol

Allow users to add double-click or right-click handlers to Container components

@linear
Copy link

linear bot commented Dec 11, 2025

@melohagan melohagan marked this pull request as ready for review December 11, 2025 12:48
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite a lot of code, what's with all this for touch events etc? Do we need it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because you can't right-click on a mobile device, so it is an accessibility consideration.

@github-actions github-actions bot added the stale label Dec 25, 2025
@melohagan melohagan removed the stale label Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants