-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Budi 9173 exposing double click or right click event in container #17604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Budi 9173 exposing double click or right click event in container #17604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite a lot of code, what's with all this for touch events etc? Do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because you can't right-click on a mobile device, so it is an accessibility consideration.
…lick-event-in-container
…lick-event-in-container
…lick-event-in-container
…lick-event-in-container
…lick-event-in-container
…lick-event-in-container
…lick-event-in-container
…lick-event-in-container
…lick-event-in-container
Description
Allow a user to add double click and right click events to a container. You must choose between onClick and onDoubleClick - you cannot have both.
Backwards compatibility for existing containers onClick was tested.
Addresses
Screenshots
Launchcontrol
Allow users to add double-click or right-click handlers to Container components