-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: allow preview chat with agents #17862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Dakuan
wants to merge
6
commits into
master
Choose a base branch
from
feat/allow-preview-chat-with-agents
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
@Dakuan I have started the AI code review. It will take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 4 files
Confidence score: 3/5
- Preview bypass in
packages/server/src/api/controllers/ai/chatConversations.tsskips chatApp agent membership checks, allowing builders to preview any agentId and potentially leak access beyond intended “disabled” scope. - Severity is medium (6/10) with plausible user-impacting access control risk, so there’s some merge risk despite otherwise limited scope.
- Pay close attention to
packages/server/src/api/controllers/ai/chatConversations.ts- ensure preview path enforces chatApp membership before allowing access.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/server/src/api/controllers/ai/chatConversations.ts">
<violation number="1" location="packages/server/src/api/controllers/ai/chatConversations.ts:217">
P2: The preview bypass skips the chatApp agent membership check. Builders can preview any agentId even if it isn’t configured for the chat app, which is broader than “disabled” and can leak access. Keep the membership check and only bypass the enabled flag.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Allow preview chat with agents in the builder. Adds a guarded preview mode for transient chats so builders can test agents without persisting conversations or enabling them.
Written for commit f3cebca. Summary will update on new commits.