Skip to content

Conversation

@melohagan
Copy link
Collaborator

@melohagan melohagan commented Jan 30, 2026

Description

Fix invalid date for TIME types in MySQL

Addresses

Screenshots

invalid date

BEFORE

after

AFTER

Test data

CREATE TABLE time_date_test (
  id INT AUTO_INCREMENT PRIMARY KEY,
  label VARCHAR(64) NOT NULL,
  d DATE NOT NULL,
  t TIME(6) NOT NULL,
  dt DATETIME(6) NOT NULL
);

INSERT INTO time_date_test (label, d, t, dt) VALUES
  ('epoch', '1970-01-01', '00:00:00.000000', '1970-01-01 00:00:00.000000'),
  ('y2k', '2000-01-01', '00:00:00.000000', '2000-01-01 00:00:00.000000'),
  ('before_dst_us', '2023-03-12', '01:59:59.000000', '2023-03-12 01:59:59.000000'),
  ('after_dst_us', '2023-03-12', '03:00:01.000000', '2023-03-12 03:00:01.000000'),
  ('leap_day', '2024-02-29', '12:34:56.000000', '2024-02-29 12:34:56.000000'),
  ('end_of_year', '2025-12-31', '23:59:59.000000', '2025-12-31 23:59:59.000000'),
  ('millis', '2025-01-30', '12:34:56.789000', '2025-01-30 12:34:56.789000'),
  ('micros', '2025-01-30', '12:34:56.789123', '2025-01-30 12:34:56.789123'),
  ('far_future', '2099-12-31', '23:59:59.000000', '2099-12-31 23:59:59.000000');

Launchcontrol

Fix for TIME fields in MySQL

@melohagan melohagan marked this pull request as ready for review January 30, 2026 10:53
@melohagan melohagan requested a review from a team as a code owner January 30, 2026 10:53
@melohagan melohagan requested review from adrinr and removed request for a team January 30, 2026 10:53
@melohagan melohagan changed the title Bug fix for TIMESTAMP fields in MySQL and Postgres Bug fix for TIME fields in MySQL Jan 30, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@melohagan melohagan requested a review from adrinr January 30, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants