Skip to content

Fix grid conditions#17924

Merged
ConorWebb96 merged 6 commits intomasterfrom
fix/grid-conditions
Feb 3, 2026
Merged

Fix grid conditions#17924
ConorWebb96 merged 6 commits intomasterfrom
fix/grid-conditions

Conversation

@ConorWebb96
Copy link
Collaborator

@ConorWebb96 ConorWebb96 commented Feb 2, 2026

Description

Fixes table button visibility conditions that rely on Current User bindings by ensuring row button condition enrichment merges the existing app context with the row context, and adds a small regression test for condition enrichment.

Addresses

  • Customer reported issue

Screenshots

Binding value
Screenshot 2026-02-02 at 10 53 50

Before fix
Screenshot 2026-02-02 at 10 54 11

After Fix
Screenshot 2026-02-02 at 10 55 38

Launchcontrol

Table buttons now have access to the extra context they need to work with the current user bindings.


Summary by cubic

Fixes grid row button visibility by resolving conditions with both Current User and row context. Buttons now show/hide correctly in tables.

  • Bug Fixes

    • Merge app context with row context when evaluating row button conditions, so Current User bindings work.
  • Refactors

    • Move condition enrichment to utils as enrichGridConditions and use it for columns and row buttons.
    • Add a regression test covering user and row binding resolution.

Written for commit c05b446. Summary will update on new commits.

@github-actions github-actions bot added the size/s label Feb 2, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Contributor

@jvcalderon jvcalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ConorWebb96 ConorWebb96 merged commit 9232cc6 into master Feb 3, 2026
24 checks passed
@ConorWebb96 ConorWebb96 deleted the fix/grid-conditions branch February 3, 2026 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants