This repository was archived by the owner on Apr 23, 2025. It is now read-only.
Bump node version to 16 in gh-workflow #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In favor of #187 we have to update the node version to
>=16because@formatjs/[email protected]requires it. checkout failed jobEven though we are doing :
It seems that yarn first does
yarn installwhich leads to installing@formatjs/[email protected]which is being usedreact-appworkspace.Current approach :
Updated the node version from
14.xto16.xand also updated the run task from :Actually, there is no need of updating
runtask but sinceyarn workspace backend installrunsyarn installprior updated it to only runyarn install.Found this approach minimal and working.
Test :
Tired doing
yarn installusing nodev16locally and it seems everything works.Also tried running gh-workflow using node v16 checkout details here( Although
testsfailed butyarn installworkded)Approches explored :
yarn workspace backend install --focus: It seems that if you use--focusoption it fetches from npm registry and it gives the below error :--focusis of no use if you haven't hosted packages on npm registry but couldn't find the reference now : (yarn install --scope @scaffold-eth/monorepo/backend: even this doesn't work : ( , it was suggested here -> install --focus should respect dependency listings and private flags yarnpkg/yarn#6715 (comment)