Skip to content

Conversation

@El-Torador
Copy link
Collaborator

@El-Torador El-Torador commented May 16, 2020

Description

Please include a summary of the change and relevant motivation and context.
List any dependencies that are required for this change.

All pull requests should be related to open issues. Indicate the issue(s) bellow and remove this line:
Fixes #(issue number 1) #(issue number 2 if applicable)

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code etc.

Screenshots (if applicable, else remove this line / section)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary inline code documentation
  • I have added tests that prove my fix is effective and that this feature works
  • New and existing unit tests pass locally with my changes

El-Torador added 30 commits May 16, 2020 04:30
Define PropTypes, props, handleSubmit method and displaying error message.
#1
Define the propTypes, props and pass it in the children components
#
Display the error message on UI
#done
Content the headers of the requests API and the API domain
#
add actions types of success auth and failed auth
#
use to connect Auth Page with redux and pass props and dispatch function
#
auth reducer takes state and action and update state
#
update the design of initial store
#
@El-Torador
Copy link
Collaborator Author

Authentification feature (Logic and interface) is done.

add props clearError, and set her prop type
#
control all the values if it's correct.
#
add spinner during the loading and set clearError to clear error message.
#
define the actions creators auth test
#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants