feat[plugin][smartling]: ENG-9736 visual context upload, exclude blocks, edit/add/delete string instructions #4218
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -163,6 +163,21 @@ Builder.register('plugin', { | |
| advanced: false, | ||
| requiredPermissions: ['admin'], | ||
| }, | ||
| { | ||
| name: 'disableVisualContextCapture', | ||
| friendlyName: 'Disable Visual Context Capture', | ||
| type: 'boolean', | ||
| defaultValue: false, | ||
| helperText: 'Disable automatic visual context capture for translations', | ||
| requiredPermissions: ['admin'], | ||
| }, | ||
| { | ||
| name: 'contextOverrideOlderThanDays', | ||
| friendlyName: 'Context Override Older Than Days', | ||
| type: 'number', | ||
| helperText: 'Override context for content older than this number of days', | ||
| requiredPermissions: ['admin'], | ||
| }, | ||
| ], | ||
| onSave: async actions => { | ||
| const pluginPrivateKey = await appState.globalState.getPluginPrivateKey(pkg.name); | ||
|
|
@@ -460,7 +475,7 @@ const initializeSmartlingPlugin = async () => { | |
| } | ||
| const element = selectedElements[0]; | ||
| const isExcluded = element.meta?.get(transcludedMetaKey); | ||
| return !isExcluded; | ||
| }, | ||
| onClick(elements) { | ||
| elements.forEach(el => el.meta.set('excludeFromTranslation', true)); | ||
|
|
@@ -476,13 +491,85 @@ const initializeSmartlingPlugin = async () => { | |
| } | ||
| const element = selectedElements[0]; | ||
| const isExcluded = element.meta?.get(transcludedMetaKey); | ||
| return isExcluded; | ||
| }, | ||
| onClick(elements) { | ||
| elements.forEach(el => el.meta.set('excludeFromTranslation', false)); | ||
| }, | ||
| }); | ||
|
|
||
|
|
||
| registerContextMenuAction({ | ||
| label: 'Add String Instructions', | ||
| showIf(selectedElements) { | ||
| if (selectedElements.length !== 1) { | ||
| // todo maybe apply for multiple | ||
| return false; | ||
| } | ||
| const element = selectedElements[0]; | ||
| return element.meta?.get('instructions') === undefined; | ||
| }, | ||
| async onClick(elements) { | ||
| if (elements.length !== 1) { | ||
| // todo maybe apply for multiple | ||
| return false; | ||
| } | ||
| const instructions = await appState.dialogs.prompt({ | ||
| placeholderText: 'Enter string instructions for translation', | ||
| }); | ||
| if (instructions) { | ||
| elements[0].meta.set('instructions', instructions); | ||
| appState.snackBar.show('String instructions added to content'); | ||
| } | ||
| }, | ||
| }); | ||
|
|
||
| registerContextMenuAction({ | ||
| label: 'Edit String Instructions', | ||
| showIf(selectedElements) { | ||
| if (selectedElements.length !== 1) { | ||
| // todo maybe apply for multiple | ||
| return false; | ||
| } | ||
| const element = selectedElements[0]; | ||
| return element.meta?.get('instructions') !== undefined; | ||
| }, | ||
| async onClick(elements) { | ||
| if (elements.length !== 1) { | ||
| // todo maybe apply for multiple | ||
| return false; | ||
| } | ||
| const element = elements[0]; | ||
| const instructions = element.meta?.get('instructions'); | ||
| if (instructions) { | ||
|
||
| const newInstructions = await appState.dialogs.prompt({ | ||
| placeholderText: 'Enter new string instructions for translation', | ||
| defaultValue: instructions, | ||
| }); | ||
| if (newInstructions) { | ||
| element.meta.set('instructions', newInstructions); | ||
| appState.snackBar.show('String instructions updated'); | ||
| } | ||
| } | ||
| }, | ||
| }); | ||
|
|
||
| registerContextMenuAction({ | ||
| label: 'Delete String Instructions', | ||
| showIf(selectedElements) { | ||
| if (selectedElements.length !== 1) { | ||
| // todo maybe apply for multiple | ||
| return false; | ||
| } | ||
| const element = selectedElements[0]; | ||
| return element.meta?.get('instructions') !== undefined; | ||
| }, | ||
| onClick(elements) { | ||
| elements[0].meta.delete('instructions'); | ||
| appState.snackBar.show('String instructions deleted'); | ||
| }, | ||
| }); | ||
|
|
||
| registerContentAction({ | ||
| label: 'Add to translation job', | ||
| showIf(content, model) { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.