Skip to content

fix: ENG-9776 AI feature not working because of custom component name which includes colon#1780

Merged
midhunadarvin merged 5 commits intoBuilderIO:mainfrom
midhunadarvin:ENG-9776
Jun 27, 2025
Merged

fix: ENG-9776 AI feature not working because of custom component name which includes colon#1780
midhunadarvin merged 5 commits intoBuilderIO:mainfrom
midhunadarvin:ENG-9776

Conversation

@midhunadarvin
Copy link
Contributor

@midhunadarvin midhunadarvin commented Jun 25, 2025

Description

Please provide the following information:

  • What changes you made:
    • if the component name contains a colon, store the original name in meta
    • during componentToBuilder transpilation use the original name in meta as the component name.
  • Why you made them, and:
    • VE AI removes the colon from the component names

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

@midhunadarvin midhunadarvin requested a review from samijaber as a code owner June 25, 2025 12:47
@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2025

🦋 Changeset detected

Latest commit: c1f28e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@midhunadarvin midhunadarvin requested review from liamdebeasi and removed request for samijaber June 25, 2025 12:48
@nx-cloud
Copy link

nx-cloud bot commented Jun 25, 2025

View your CI Pipeline Execution ↗ for commit c1f28e1.

Command Status Duration Result
nx e2e @builder.io/e2e-app ✅ Succeeded 1m 56s View ↗
nx run-many --target test ✅ Succeeded 5m 5s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 3m 46s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded 2m 37s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-27 16:08:52 UTC

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go once unused variable is removed. nice work!

},
};

const el = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem to be used anywhere

@midhunadarvin midhunadarvin enabled auto-merge (squash) June 27, 2025 16:01
@midhunadarvin midhunadarvin merged commit f442a8c into BuilderIO:main Jun 27, 2025
7 checks passed
@midhunadarvin midhunadarvin deleted the ENG-9776 branch June 27, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants