Add FromBytesRadix trait + impl + error types#120
Open
alexjago wants to merge 8 commits intoBurntSushi:masterfrom
Open
Add FromBytesRadix trait + impl + error types#120alexjago wants to merge 8 commits intoBurntSushi:masterfrom
FromBytesRadix trait + impl + error types#120alexjago wants to merge 8 commits intoBurntSushi:masterfrom
Conversation
lopopolo
reviewed
Jul 21, 2022
lopopolo
reviewed
Jul 22, 2022
Co-authored-by: Ryan Lopopolo <rjl@hyperbo.la>
Co-authored-by: Ryan Lopopolo <rjl@hyperbo.la>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows after discussion and work on #64.
Importing the trait
FromBytesRadixwill provide{integer}::from_bytes_radix(...)for integer types, analogous to{integer}::from_str_radix(...)but operating on an&dyn AsRef<[u8]>rather than an&str.Error types
ParseIntErrorandIntErrorKindare also provided, copying the standard library.Note:
IntErrorKindcopies the post-1.55 version; once the crate MSRV is bumped it can probably be replaced with a simplepub use core::num::IntErrorKind.