Switch serde dependency to serde_core
#403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolobarbolini
force-pushed
the
switch-to-serde-core
branch
from
6e2c22a to
9a603ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serde_core has just been released. Crates that don't depend on serde derive macros should use it instead of
serde, as it speeds up compile times by having the build for the crate itself be independent fromserde-derive(in case it were to be enabled by some other crate). See the serde_core docs for more info.While at it this also removes uses of
serde::serde_if_integer128!, since all supported Rust versions in modern versions of serde support 128 bit integers https://github.com/serde-rs/serde/blob/3f6925125bae7837d918da63f2dba6efabad8dec/serde/src/integer128.rs.On my Ryzen 5 5500U, the clean release build time for just
csvin a project containingcsv, andserdewith thederivefeature enabled, went from 6.97s to 4.06s.