Skip to content

allow srcs in py_console_script_binary when using py_test as the binary #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

allow srcs in py_console_script_binary when using py_test as the binary #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions python/private/py_console_script_binary.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Implementation for the macro to generate a console_script py_binary from an 'ent
"""

load("//python:py_binary.bzl", "py_binary")
load("//python:py_test.bzl", "py_test")
load(":py_console_script_gen.bzl", "py_console_script_gen")

def _dist_info(pkg):
Expand Down Expand Up @@ -72,8 +73,14 @@ def py_console_script_binary(
"""
main = "rules_python_entry_point_{}.py".format(name)

if kwargs.pop("srcs", None):
srcs = kwargs.pop("srcs", [])

if binary_rule == py_test:
srcs = srcs + [main]
elif srcs:
fail("passing 'srcs' attribute to py_console_script_binary is unsupported")
else:
srcs = [main]

py_console_script_gen(
name = "_{}_gen".format(name),
Expand All @@ -86,7 +93,7 @@ def py_console_script_binary(

binary_rule(
name = name,
srcs = [main],
srcs = srcs,
main = main,
deps = [pkg] + kwargs.pop("deps", []),
**kwargs
Expand Down