Closes #279: use $CARGO_HOME as default location if defined #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
requested changes
Mar 30, 2025
Owner
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for making this happen, it's much appreciated!
Once this is finalised I think the changes should also be contributed to the source of this copy for maximum impact.
| if [ -z $dest ]; then | ||
| dest="$HOME/.cargo/bin" | ||
| if [ -z "$dest" ]; then | ||
| dest="${CARGO_HOME:-$HOME/.cargo/bin}" |
Owner
There was a problem hiding this comment.
This doesn't seem correct as per the definition of $CARGO_HOME.
This seems more like it.
Suggested change
| dest="${CARGO_HOME:-$HOME/.cargo/bin}" | |
| dest="${CARGO_HOME:-$HOME/.cargo}/bin" |
What do you think?
| --tag TAG Tag (version) of the crate to install (default <latest release>) | ||
| --target TARGET Install the release compiled for $TARGET (default <`rustc` host>) | ||
| --to LOCATION Where to install the binary (default ~/.cargo/bin) | ||
| --to LOCATION Where to install the binary (default '$CARGO_HOME' if defined, otherwise '~/.cargo/bin') |
Owner
There was a problem hiding this comment.
Suggested change
| --to LOCATION Where to install the binary (default '$CARGO_HOME' if defined, otherwise '~/.cargo/bin') | |
| --to LOCATION Where to install the binary (default '$CARGO_HOME/bin' if defined, otherwise '~/.cargo/bin') |
More context is in the comment below.
Owner
|
Closing due to inactivity. Please feel free to reopen once there is some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a 2nd commit which addresses unquoted variables names preventing shell globbing or word splitting.