Add single-rank lsq pseudoinv factory test#1099
Conversation
|
cscs-ci run default |
msimberg
force-pushed
the
lsq-pseudoinv-factory-test
branch
from
e71006f to
0c2ec7d
Compare
|
cscs-ci run default |
|
cscs-ci run default |
model/common/src/icon4py/model/common/interpolation/interpolation_factory.py
Outdated
Show resolved
Hide resolved
|
cscs-ci run default |
|
cscs-ci run default |
|
cscs-ci run default |
|
cscs-ci run distributed |
|
cscs-ci run default |
|
cscs-ci run distributed |
nfarabullini
left a comment
nfarabullini
left a comment
There was a problem hiding this comment.
Small edits here and there
| TODO: | ||
| replace this with a suitable library call |
There was a problem hiding this comment.
do we still need this TODO?
There was a problem hiding this comment.
I suspect it's still as valid as before (this PR doesn't change the validity).
There was a problem hiding this comment.
but do we need it at all? I'm just confused of what kinf of library call should be used here instead of this function
There was a problem hiding this comment.
It's a fair question though I'll leave that consideration out of this PR.
It looks like @ajocksch added this functionality and the TODO, maybe you can comment if you think the TODO is still useful? If not, we can remove it separately.
model/common/tests/common/interpolation/unit_tests/test_interpolation_factory.py
Outdated
Show resolved
Hide resolved
…olation_factory.py Co-authored-by: Nicoletta Farabullini <41536517+nfarabullini@users.noreply.github.com>
|
cscs-ci run default |
|
cscs-ci run distributed |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
2 participants
Related to #1065 (comment). This uses @nfarabullini's fixes for doing the LSQ_PSEUDOINV computation with a GPU backend from #1012 to have them merged separately.
This also adds LSQ_PSEUDOINV to the parallel test in test_parallel_grid_manager.py. This required changing the computation to avoid doing the SVD on halo points.
Custom dimensions are added for LSQ_PSEUDOINV to correctly declare the dimensions in the factory. Previously the dimension was equivalne to a scalar, which lead to the factory returning the plain numpy array. With this change the mypy type ignores can be removed from test_parallel_interpolation.py.