Remove testvectors/ in favour of testvectors_v1#169
Merged
Conversation
In preparation for removing `testvectors/` in favour of just `testvectors_v1/`.
The project is consolidating maintenance effort on `testvectors_v1/`, so this commit removes the original "v0" `testvectors/` directory. Users relying on the removed content can continue to use Wycheproof the git tag created from the parent of this commit (`wycheproof-v0-vectors`), but should consider adopting the v1 vectors in order to receive new algorithm coverage and other related fixes/updates.
Now that the `testvectors/` directory has been removed, delete any schema files that aren't used by `testvectors_v1/`.
* Put stuff in `testvectors_v1/` now that `testvectors/` is gone (and not, for e.g., in `schemas/` alongside schema files) * Try to capture some guidance for source metadata based on conversations with new contributors.
* Priorities are updated to remove the dir consolidation since that's ~done. * FAQ item about v0 vs v1 is updated to point to where the v0 directory went (incl. a pointer to a tag created at the parent of the removal commit).
This was referenced Aug 20, 2025
FiloSottile
approved these changes
Sep 2, 2025
Contributor
|
Thanks for doing this. Without this, I'd probably have postponed the migration of our tests to v1 forever since there was always more important stuff to do. |
bob-beck
pushed a commit
to openbsd/src
that referenced
this pull request
Sep 4, 2025
In C2SP/wycheproof#169, upstream removed the testvector/ path, thereby creating the need to migrate if we want to benefit from future changes and tests. While this has been around for a very long time and generally provided more and better coverage, there never was sufficient motivation to do so. As a first step, change use of the testVectorPath constant to use of a path variable so we can switch the tests one by one by appending _v1 when appropriate.
botovq
pushed a commit
to libressl/openbsd
that referenced
this pull request
Sep 13, 2025
In C2SP/wycheproof#169, upstream removed the testvector/ path, thereby creating the need to migrate if we want to benefit from future changes and tests. While this has been around for a very long time and generally provided more and better coverage, there never was sufficient motivation to do so. As a first step, change use of the testVectorPath constant to use of a path variable so we can switch the tests one by one by appending _v1 when appropriate.
nak3
pushed a commit
to nak3/openbsd
that referenced
this pull request
Nov 23, 2025
In C2SP/wycheproof#169, upstream removed the testvector/ path, thereby creating the need to migrate if we want to benefit from future changes and tests. While this has been around for a very long time and generally provided more and better coverage, there never was sufficient motivation to do so. As a first step, change use of the testVectorPath constant to use of a path variable so we can switch the tests one by one by appending _v1 when appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #151
I tagged
wycheproof-v0-vectorsfrom the SHA I branched off of for this work as a convenient way for downstream users to gettestvectors/before the removal.