Conversation
botovq
approved these changes
Nov 12, 2025
Contributor
|
There are better people among the reviewers to evaluate go here, but this looks indeed handy. |
Member
Author
|
@FiloSottile flipped through this while we were on a call, suggested some review feedback:
I'll address both items shortly. |
This allows downstream Go code to import this repo and directly access JSON schema files and JSON test vector files using a FS interface (listing files, reading content, etc).
Member
Author
Done, and the usage example in the PR description was updated accordingly. I'll merge this in the next few days unless there's any new feedback. |
sgmenda
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows downstream Go code to import this repo and directly access JSON schema files and JSON test vector files using a FS interface (listing files, reading content, etc).
We already have a
go.modto manage the Govectorlintprogram. I believe this addition meets the language specific ecosystem considerations. I will be relying on it downstream and commit to helping keep it working.Example usage: