x25519/x448: audit and fixup Twist flag test cases#198
Merged
Conversation
Several low order public key tests specify twist x points but were missing the appropriate flag.
These testcases are not on the twist.
Contributor
|
Yep looks good, nice touch adding support for all test formats in twist check. And yeah I forgot forking the repo and then comparing would mean you can't push the change, I just did that so I could use the forks json link until it was fixed, thanks! |
Contributor
|
Can confirm all the tests (including x25519) now pass for this now |
rolandshoemaker
approved these changes
Dec 1, 2025
Member
Author
Will leave it for now. Easy to rm in the future if new opinions emerge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is an extension of #196 with a few differences. Please check my work :-)
x25519_test.jsontest case (tcId 101) that @XoifaiI flagged was also present in thex25519_pem_test.jsonandx25519_jwk_test.jsonvariations. I amended their commit to fix these instances in the same manner as was done inx25519_test.json(Another point in favour of having less formats...)I've included the program I wrote to lint these files, and integrated it with CI. This is mainly so others can check my work. I could be convinced it's not worth including the tool + CI integration. Please chime in if you have opinions here.