Split MLKEM schemas + vector files by test group type#199
Merged
Conversation
Member
|
I'd argue that a |
* Splits the unified schema into two instances, one tailored for general MLKEM and one tailored to encaps. * Splits the mlkem test data files into two based on the above schemas. Care is taken to make sure only applicable note flags are carried over.
Member
Author
Fair point! I've reworked as suggested. |
sgmenda
approved these changes
Dec 5, 2025
Contributor
sgmenda
left a comment
There was a problem hiding this comment.
lgtm, thank you very much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement for #192 with a few tweaks:
mlkem_encaps_test_schema.jsonandmlkem_test_schema.jsonfor the schemas,mlkem_$SIZE_encaps_test.jsonandmlkem_$SIZE_test.jsonfor the test files).vectorlintso CI will catch any violations of this property in the future.Thanks to @dingxiangfei2009 for getting the ball rolling on this. 🙇
Resolves #191