Lowercase hex in ML-DSA sign seed test vectors#219
Merged
Conversation
Member
|
This seems reasonable to me, but also like something that might be nice to enforce in CI. WDYT? |
The json-schema package we're using will already prefix validation errors with the value that failed validation. This commit removes the value from the errors we produce in custom validators to avoid duplicating it in output.
Member
I pushed two small tool update commits to add CI verification that hex bytes format values are lowercase. Hope you don't mind! Example output from applying the updated linter to this branch with 7d30358 reverted: |
cpu
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ML-DSA sign seed test vectors use uppercase hex, inconsistent with the rest of the repo.
Lowercases privateSeed hex values in mldsa_{44,65,87}_sign_seed_test.json.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.