Open
Conversation
Contributor
Author
|
Since the bot cannot run when the PR comes from a fork, here is a copy from our fork for informational purposes: New testcasesThere are new testcases in this change. openssl-3.6.0
openssl-3.2.6
openssl-3.5.4
pyca-cryptography-46.0.3
rust-webpki
openssl-1.1
openssl-3.0.18
openssl-3.4.3
gnutls-certtool-3.8.3
certvalidator-0.11.1
gocryptox509-go1.25.5
rustls-webpki
openssl-3.3.5
|
b22ac62 to
35dcf1e
Compare
35dcf1e to
559fbb8
Compare
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
559fbb8 to
62b88f0
Compare
Collaborator
|
These tests look right to me, but I'm confused as to why we're skipping them on the PyCA harness. These seem useful to run there 🙂 |
Contributor
Author
|
Because these are pedantic EKU tests and PyCA doesn't support those (which is a pre-existing choice) x509-limbo/harness/pyca-cryptography/main.py Lines 29 to 31 in 9d59474 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test cases for CABF Baseline Requirements 7.1.2.10.6 regarding CA Extended Key Usage (EKU) validation.
There are 9 new test cases:
ca_without_serverauth_issuing_tls: Tests rejection when onlyclientAuthis present.ca_with_precertificate_oid: Tests rejection when only precertificate OID is present.ca_with_serverauth_and_precertificate: Tests rejection whenserverAuthand precertificate OID are present.ca_with_serverauth_issuing_matching: Tests acceptance whenserverAuthpresent.ca_with_codesigning_eku: Tests rejection whenserverAuthand `` are present.ca_with_emailprotection_eku: Tests rejection whenserverAuthandemailProtectionare present.ca_with_timestamping_eku: Tests rejection whenserverAuthandtimeStampingare present.ca_with_ocspsigning_eku: Tests rejection whenserverAuthandOCSPSigningare present.ca_with_anyeku: Tests rejection whenserverAuthandanyExtendedKeyUsageare present.🤖 Generated with Claude Code