feat: bulk job deletion with multi-select UI. Closes #445#481
Merged
C4illin merged 8 commits intoC4illin:mainfrom Dec 26, 2025
Merged
feat: bulk job deletion with multi-select UI. Closes #445#481C4illin merged 8 commits intoC4illin:mainfrom
C4illin merged 8 commits intoC4illin:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (all 2 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/pages/deleteJob.tsx">
<violation number="1" location="src/pages/deleteJob.tsx:112">
P2: The `jobIds` array has no maximum size limit. Consider adding `maxItems` to prevent potential DoS attacks where a malicious user submits thousands of IDs, causing excessive database queries and prolonged request processing.</violation>
</file>
<file name="src/pages/history.tsx">
<violation number="1" location="src/pages/history.tsx:299">
P2: Missing `response.ok` check before processing the fetch response. If the server returns an HTTP error status (4xx/5xx), the code will still attempt to process the response body and may show incorrect success/failure messages. Check `response.ok` or `response.status` before parsing the response.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Owner
Contributor
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/pages/history.tsx">
<violation number="1" location="src/pages/history.tsx:57">
P2: Invalid HTML: `<p>` element inside `<button>` is not allowed. Button elements can only contain phrasing content, but `<p>` is flow content. Use `<span>` instead for valid markup.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Contributor
Author
142ca51 to
cf28284
Compare
Owner
|
What would you think about having it grayed out all the time so we don't have the bounce when it is shown? Or make it shorter so that it fits without expanding |
…I with client-side deletion logic into the history page.
…ponse error handling.
…utton, including new button styling and icon
…cted instead of hidden
260bd2c to
bd05f37
Compare
evil9369
pushed a commit
to pi-docket/ConvertX-CN
that referenced
this pull request
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add mass delete functionality to job history
Closes #445
Adds the ability to select and delete multiple jobs at once from the history page.
Changes
/delete-multiplePOST endpoint that processes deletions sequentiallyTechnical notes
Summary by cubic
Adds bulk job deletion to the history page with multi-select checkboxes and a Delete Selected action. The server deletes selected jobs sequentially with ownership checks and returns detailed success/failure counts, addressing #445.
Written for commit bd05f37. Summary will update automatically on new commits.