{model}Store を {model}Repositoryに変更 & CategoryFilterをFireStoreで#54
Open
{model}Store を {model}Repositoryに変更 & CategoryFilterをFireStoreで#54
Conversation
ho2ri2s
requested review from
b4tchkn and
ry-itto
and removed request for
ry-itto
Flutter Analyze found 0 issues ✅LGTM 🎉 Generated by 🚫 Danger |
ho2ri2s
commented
May 25, 2020
Contributor
Author
ho2ri2s
left a comment
ho2ri2s
left a comment
There was a problem hiding this comment.
Profileマージして設計整えるぞ！
Comment on lines
+80
to
+83
| Future<void> filterArticles(Category category) async { | ||
| articles = await _client.getFilteredArticles(category.id); | ||
| notifyListeners(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
なぜかファイルごとaddな差分になってしまってるけど、変更した箇所はここと、
それぞれのメソッドのtry-catchを一時的に外した感じ
Contributor
There was a problem hiding this comment.
今View に入ってる Repository はふさわしい Store で置き換えられる認識でいいよね？
Contributor
Author
There was a problem hiding this comment.
そうやね！HomeStoreとかProfileStoreとかな感じ！
ry-itto
approved these changes
May 25, 2020
Contributor
Author
|
Profileマージしてからコンフリクト直しまっす |
Contributor
|
🙏 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
やったこと
try-catchはStoreでやる運用とするために一時的に外した