Conversation
Member
Author
|
[共有事項] |
zoothezoo
reviewed
Jun 14, 2020
zoothezoo
reviewed
Jun 14, 2020
| child: const Text('OK'), | ||
| color: Theme.of(context).accentColor, | ||
| onPressed: () async { | ||
| // await context.read<InputParticipantInfoController>().handlePost(); |
zoothezoo
reviewed
Jun 14, 2020
| return FlatButton( | ||
| child: const Text('ok'), | ||
| child: const Text('OK'), | ||
| color: Theme.of(context).primaryColor, |
zoothezoo
reviewed
Jun 14, 2020
Contributor
zoothezoo
left a comment
zoothezoo
left a comment
There was a problem hiding this comment.
良さそう！
メッセージ確認してもらったら、Approveする！
Member
Author
|
#94 でBugFix |
ryu1sazae
reviewed
Jun 14, 2020
| import 'package:morning_weakers/pages/input_participant_info/input_participant_info_page.dart'; | ||
|
|
||
| class Menu extends StatelessWidget { | ||
| final List<List<String>> menus = [ |
Contributor
There was a problem hiding this comment.
Suggested change
| final List<List<String>> menus = [ | |
| final List<List<String>> _menus = [ |
privateにできそう
| return Column( | ||
| children: menus | ||
| .map( | ||
| (button) => ListTile( |
Contributor
There was a problem hiding this comment.
Suggested change
| (button) => ListTile( | |
| (buttonTitle) => ListTile( |
の方が良さげ？
tomu28
force-pushed
the
feature/tomu28/connection_of_page
branch
from
2395147 to
4b10b62
Compare
Member
Author
|
mergeするね！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
対応するIssues番号
close #82