Skip to content

Conversation

@reza0310
Copy link

PLEASE NOTE: All of this have been tested but only with CLI. I don't really know neither can test the GUI but I hope it doesn't rely on bad error management.

reza0310 and others added 3 commits October 21, 2025 14:41
Patched some typos from the README
PLEASE NOTE: All of this have been tested but only with CLI. I don't really know neither can test the GUI but I hope it doesn't rely on bad error management.
@reza0310
Copy link
Author

PLEASE squash before merging. Commits c3a8deb and c962aeb don't have anything to do here and doesn't add any changes to this PR. I just screwed up a little.

@reza0310
Copy link
Author

Also please note that PR #191 removes the same line as this PR in openEDSfile function. Shouldn't have any impact but I'd rather warn than cause problems.

@reza0310 reza0310 mentioned this pull request Oct 21, 2025
@reza0310
Copy link
Author

Files used for testing:

@reza0310 reza0310 requested a review from nimrof October 21, 2025 15:41
Copy link
Collaborator

@nimrof nimrof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@nimrof nimrof merged commit c86a092 into CANopenNode:main Oct 28, 2025
4 checks passed
@reza0310 reza0310 deleted the patch-4 branch November 4, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants