Upgrade Octokit authentication to fix deprecation warnings#1344
Merged
Arif-Khalid merged 4 commits intoCATcher-org:masterfrom Mar 15, 2025
Merged
Conversation
Contributor
Author
|
After upgrading Screen.Recording.2025-03-10.at.2.11.50.PM.movAfter my changes adding in the Screen.Recording.2025-03-10.at.2.13.44.PM.mov |
Arif-Khalid
requested changes
Mar 10, 2025
Contributor
Arif-Khalid
left a comment
There was a problem hiding this comment.
Good research into the issue and an excellent resolution.
Everything remains working, good work!
Just a minor update to a renamed library method required.
| "@octokit/rest": "^16.37.0", | ||
| "@octokit/auth-oauth-user": "^2.1.2", | ||
| "@octokit/core": "^4.2.1", | ||
| "@octokit/rest": "^17.11.0", |
Contributor
There was a problem hiding this comment.
The newer version of octokit has resulted in the additional error of GithubService: octokit.repos.getContents() has been renamed to octokit.repos.getContent() showing up in the logs.
Please change the method call in GithubService to reflect the updated name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #1343
Changes Made:
@octokit/restto v17@octokit/auth-oauth-userfor indicatingauthStrategyusedProposed Commit Message: