Skip to content

Fix bug related to assignees dropdown showing old values #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arif-Khalid merged 2 commits into from
Mar 24, 2025
Merged

Fix bug related to assignees dropdown showing old values #1349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae9368
Fix bug related to assignees dropdown showing old values
yucongkoo Mar 24, 2025
66b683b
Make AssigneeComponent implement OnChanges
yucongkoo Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/app/shared/issue/assignee/assignee.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, EventEmitter, Input, OnInit, Output, ViewChild, ViewEncapsulation } from '@angular/core';
import { Component, EventEmitter, Input, OnChanges, OnInit, Output, SimpleChanges, ViewChild, ViewEncapsulation } from '@angular/core';
import { MatSelect } from '@angular/material/select';
import { first } from 'rxjs/operators';
import { Issue } from '../../../core/models/issue.model';
Expand All @@ -14,7 +14,7 @@ import { PhaseService } from '../../../core/services/phase.service';
styleUrls: ['./assignee.component.css'],
encapsulation: ViewEncapsulation.None
})
export class AssigneeComponent implements OnInit {
export class AssigneeComponent implements OnInit, OnChanges {
teamMembers: string[];
isInEditMode = false;
assignees: string[];
Expand All @@ -39,6 +39,12 @@ export class AssigneeComponent implements OnInit {
this.assignees = this.issue.assignees.map((a) => a);
}

ngOnChanges(changes: SimpleChanges) {
Copy link
Copy Markdown
Contributor

@Arif-Khalid Arif-Khalid Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As warned by the github actions, please inherit from the OnChanges interface

if (changes['issue']) {
this.assignees = [...(this.issue?.assignees || [])];
}
}

openSelector() {
this.isInEditMode = true;
this.assigneeSelection.open();
Expand Down