Show review decision and reviewers in PR card#449
Show review decision and reviewers in PR card#449NorbertLoh merged 43 commits intoCATcher-org:mainfrom
Conversation
|
@wx-03 shall we show all these stuff in the same line (but overflow to next line if cannot fit in one line), to optimise vertical space usage? |
I have updated it to show the review decision icon on the right side of the reviewers, and it will now be on the same line as the labels and milestone, unless there is not enough space. |
Eclipse-Dominator
left a comment
There was a problem hiding this comment.
The functionality looks great!
For minor improvements, some small refactoring can be done, otherwise its lgtm
I also noticed some unusual errors that seem to be coming from GitHub's side:

It’s unclear if this requires additional logic to address since its a respond from the graphql servers (I think), so we can leave this as a potential future issue for now.
src/app/shared/issue-pr-card/issue-pr-card-reviewers/issue-pr-card-reviewers.component.html
Show resolved
Hide resolved
src/app/shared/issue-pr-card/issue-pr-card-reviewers/issue-pr-card-reviewers.component.html
Outdated
Show resolved
Hide resolved
src/app/shared/issue-pr-card/issue-pr-card-reviewers/issue-pr-card-reviewers.component.css
Show resolved
Hide resolved
Co-authored-by: ZQ <e0725180@u.nus.edu>
Co-authored-by: ZQ <e0725180@u.nus.edu>
@Eclipse-Dominator Thanks for the review, I have made the necessary changes. |
Eclipse-Dominator
left a comment
There was a problem hiding this comment.
LGTM for me.
Let's see what others think about the design changes.



Summary:
Fixes #408
Fixes #443
Type of change:
Changes Made:
Screenshots:
When the icons and avatars are unable to fit into the same line as the labels and milestone, they will be wrapped to the next line:
Proposed Commit Message:
Checklist: