Skip to content

Remove back and home button#450

Merged
HollaG merged 2 commits intoCATcher-org:mainfrom
IzN432:remove-back-button
Apr 7, 2025
Merged

Remove back and home button#450
HollaG merged 2 commits intoCATcher-org:mainfrom
IzN432:remove-back-button

Conversation

@IzN432
Copy link
Copy Markdown
Contributor

@IzN432 IzN432 commented Mar 24, 2025

Summary:

Fixes #448

Type of change:

  • 🐛 Bug Fix

Changes Made:

  • Remove the back button (Currently, it just runs location.back(), which is not particularly needed functionality for WATcher)
  • Remove the click function of the WATcher vX.X.X button. (This button is very buggy and causes errors. The functionality is carried over from CATcher and is not needed in WATcher)

Proposed Commit Message:

Remove back and home buttons

The back button and home button have ambiguous functions, and can
occasionally cause error messages to pop up.

This confuses the user, especially when they expect the back button to
bring them back to the repository selection page.

Let's remove the back and home buttons.

The back and home buttons are relics brought over from CATcher and do
not contribute significantly to WATcher's functionality. So, they can
and should be removed.

Checklist:

  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

@IzN432 IzN432 added this to the Release 1.3.1 milestone Mar 24, 2025
Copy link
Copy Markdown
Contributor

@HollaG HollaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should remove the relevant code since it is no longer being used?

Copy link
Copy Markdown
Contributor

@HollaG HollaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HollaG HollaG merged commit 004311a into CATcher-org:main Apr 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Back button does not seem to work

2 participants