checks in get_latest_roots that all IDs are current#138
Open
ilexaquifolium wants to merge 1 commit intoCAVEconnectome:masterfrom
Open
checks in get_latest_roots that all IDs are current#138ilexaquifolium wants to merge 1 commit intoCAVEconnectome:masterfrom
ilexaquifolium wants to merge 1 commit intoCAVEconnectome:masterfrom
Conversation
Collaborator
|
Thanks for this, i'm going to look into these examples to make sure that I understood what went wrong in this case. I don't want to add another round trip call that slows things down when there could be a fix applied to the backend code instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases where a change has been made to a non-current version of the neuron, IDs that are not current IDs can be returned by get_latest_roots(). Example:
this can lead to suggest_latest_roots() also suggesting an ID that is not current:
This small alteration adds a check for these IDs and removes them.