Skip to content

Commit e56fbfb

Browse files
yngrdynCAWilson94
authored andcommitted
[Dataset quality] Redirecting to discover from wired and classic streams (elastic#234547)
in elastic#230442 we integrated dataset quality to streams. In there we identified a small bug when navigating to discover: In the original version of dataset quality we were relying in the `${type}-${dataset}-${namespace}` shape but streams has a different one, so instead of splitting the rawName of the dataset we are now redirecting using it as it is. Since the integration is targeting `9.2` no backport is required.
1 parent c7ce3b9 commit e56fbfb

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality_details/quality_issue_flyout/failed_docs/error_stacktrace_link.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const ErrorStacktraceLink = ({
3030
});
3131

3232
const { linkProps } = useRedirectLink({
33-
dataStreamStat: datasetDetails,
33+
dataStreamStat: datasetDetails.rawName,
3434
query,
3535
sendTelemetry,
3636
timeRangeConfig: timeRange,

x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality_details/quality_issue_flyout/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export default function QualityIssueFlyout() {
7272
});
7373

7474
const redirectLinkProps = useRedirectLink({
75-
dataStreamStat: datasetDetails,
75+
dataStreamStat: datasetDetails.rawName,
7676
timeRangeConfig: timeRange,
7777
query: {
7878
language: 'kuery',

x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_quality_issues_docs_chart.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ export const useQualityIssuesDocsChart = () => {
177177
});
178178

179179
const redirectLinkProps = useRedirectLink({
180-
dataStreamStat: datasetDetails,
180+
dataStreamStat: datasetDetails.rawName,
181181
query: { language: 'kuery', query },
182182
timeRangeConfig: timeRange,
183183
breakdownField: breakdownDataViewField?.name,

x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_redirect_link.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,14 +163,15 @@ const getDataView = <T extends BasicDataStream | string>({
163163
dataStreamStat: T;
164164
selector?: DataStreamSelector;
165165
}): { dataViewId: string; dataViewTitle: string } => {
166+
const dataViewSelector = selector ? `${selector}` : '';
166167
if (dataStreamStat && typeof dataStreamStat === 'string') {
167-
return { dataViewId: dataStreamStat, dataViewTitle: dataStreamStat };
168+
const dataViewId = `${dataStreamStat}${dataViewSelector}`;
169+
return { dataViewId, dataViewTitle: dataViewId };
168170
}
169171

170172
const { name, namespace, type, integration } = dataStreamStat as BasicDataStream;
171173

172174
const dataViewNamespace = `${namespace || '*'}`;
173-
const dataViewSelector = selector ? `${selector}` : '';
174175
const dataViewId = `${type}-${name}-${dataViewNamespace}${dataViewSelector}`;
175176
const dataViewTitle = integration
176177
? `[${integration.title}] ${name}-${dataViewNamespace}${dataViewSelector}`

0 commit comments

Comments
 (0)